Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract order user by name #3529

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Abstract order user by name #3529

merged 3 commits into from
Sep 11, 2023

Conversation

ghickman
Copy link
Contributor

@ghickman ghickman commented Sep 6, 2023

Found while convering Project.org to an M2M. I suspect there are more places but didn't want to look too hard while working on the M2M transition.

Ref: #2827

As per the comment ordering Users is a little complex currently, but
expected to go away at some point.  By wrapping the base get_queryset
output of the manager we can use this method directly on objects but
also further along a chain of methods.
Copy link
Contributor

@madwort madwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one typo though

jobserver/models/core.py Outdated Show resolved Hide resolved
@ghickman ghickman merged commit 38a9dcc into main Sep 11, 2023
6 checks passed
@ghickman ghickman deleted the abstract-order-user-by-name branch September 11, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants