Replace org breadcrumbs #3348
Merged
Replace org breadcrumbs #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomodwyer
reviewed
Jul 31, 2023
templates/job_request_detail.html
Outdated
| @@ -36,6 +35,11 @@ <h1 class="text-3xl tracking-tight break-words font-bold text-slate-900 sm:text- | |||
| Job request: {{ job_request.pk }} | |||
| </h1> | |||
| <dl class="flex flex-col gap-2 text-sm text-slate-600 items-center sm:flex-row sm:gap-x-6 sm:justify-center lg:justify-start"> | |||
There was a problem hiding this comment.
Tiny styling tweak:
- Add class
leading-snugto theh1 - Add class
mt-1to thedl
There was a problem hiding this comment.
leading-snug is overridden by sm:text-4xl at all widths, is that expected?
tomodwyer
approved these changes
Jul 31, 2023
ghickman
force-pushed
the
replace-org-breadcrumbs
branch
from
b58ac51 to
52c4f57
Compare
They're no longer part of the URL structure so organising information under them doesn't make much sense here. This also adds the Org icon to the JobRequest page alongside the other icons.
ghickman
force-pushed
the
replace-org-breadcrumbs
branch
from
52c4f57 to
aac725f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the Organisation breadcrumb from all pages.
This related to #2827 which is turning out to be somewhat onerous, and this is the first of probably a few chunks to make reviewing the changes manageable.