Merge pull request #4688 from opensafely-core/replace-eslint

Replace ESLint and Prettier with Biome

.gitignore

@@ -8,6 +8,7 @@
 __pycache__
 /assets/dist
 /assets/stats.html
+/assets/src/scripts/outputs-viewer/coverage
 /coverage
 /docker/staticfiles/*
 /htmlcov

assets/src/scripts/_event-log.js

@@ -19,7 +19,9 @@ if (document.getElementById("eventLog")) {
     });
   });
 
+  // biome-ignore lint/correctness/noUndeclaredVariables: ESLint to Biome legacy ignore
   $(() => {
+    // biome-ignore lint/correctness/noUndeclaredVariables: ESLint to Biome legacy ignore
     $('[data-toggle="tooltip"]').tooltip();
   });
 }

assets/src/scripts/analysis-request-detail.js

@@ -110,9 +110,7 @@ function generatePDF() {
 function formatNumbers() {
   const numbers = document.querySelectorAll(`[data-format-number="true"]`);
   numbers?.forEach(
-    // eslint-disable-next-line no-return-assign
     (number) =>
-      // eslint-disable-next-line no-param-reassign
       (number.textContent = parseFloat(number.textContent).toLocaleString(
         "en-GB",
       )),

assets/src/scripts/application-form.js

@@ -1,4 +1,3 @@
-/* eslint-disable array-callback-return, no-param-reassign */
 const content = document?.getElementById("applicationForm");
 const links = content?.getElementsByTagName("a");
 

assets/src/scripts/components.js

@@ -15,7 +15,6 @@ document.addEventListener("DOMContentLoaded", () => {
   const ul = document.getElementById("table-of-contents");
 
   anchors.forEach((heading) => {
-    // eslint-disable-next-line no-param-reassign
     heading.id = `${slugify(heading.textContent, {
       lower: true,
       strict: true,

assets/src/scripts/interactive/components/Alert.jsx

@@ -6,7 +6,6 @@ const beforeUnloadListener = (event) => {
   event.preventDefault();
   // https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#examples
   // @ts-ignore
-  // eslint-disable-next-line no-return-assign, no-param-reassign
   return (event.returnValue = "");
 };
 

assets/src/scripts/interactive/components/Button.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable react/button-has-type */
 import { bool, func, node, oneOf, string } from "prop-types";
 import React from "react";
 import { classNames } from "../utils";

assets/src/scripts/interactive/components/Tabs/TabList.jsx

@@ -1,4 +1,4 @@
-import { TabList, Tab } from "@headlessui/react";
+import { Tab, TabList } from "@headlessui/react";
 import { useAppData } from "../../context";
 import { classNames } from "../../utils";
 

assets/src/scripts/interactive/components/Textarea.jsx

@@ -22,9 +22,10 @@ function Textarea({
 }) {
   const { setFieldValue, values } = useFormikContext();
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ESLint to Biome legacy ignore
   useEffect(() => {
     setFieldValue(id, values[id] || value);
-  }, []); // eslint-disable-line react-hooks/exhaustive-deps
+  }, []);
 
   return (
     <div className={`flex flex-col gap-y-3 text-lg leading-tight ${className}`}>

assets/src/scripts/interactive/data/schema.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import * as Yup from "yup";
 
 export const codelistSchema = (pageData) =>

assets/src/scripts/interactive/utils/index.js

@@ -6,7 +6,6 @@ export function classNames(...classes) {
 }
 
 export function delay(ms) {
-  // eslint-disable-next-line no-promise-executor-return
   return new Promise((res) => setTimeout(res, ms));
 }
 
@@ -68,7 +67,6 @@ export function getAppData({
 }
 
 export const removeUndefinedValuesFromObject = (obj) => {
-  // eslint-disable-next-line no-param-reassign
   Object.keys(obj).forEach((key) => obj[key] === undefined && delete obj[key]);
   return obj;
 };

assets/src/scripts/interactive/utils/query-text.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/prefer-default-export */
-
 export const queryText = [
   "The number of people who had",
   "added to their health record each month from",

assets/src/scripts/interactive/utils/scrollToTop.jsx

@@ -4,6 +4,7 @@ import { useLocation } from "wouter";
 export default function ScrollToTop() {
   const [pathname] = useLocation();
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ESLint to Biome legacy ignore
   useEffect(() => {
     window.scrollTo(0, 0);
   }, [pathname]);

assets/src/scripts/outputs-viewer/App.jsx

@@ -1,7 +1,7 @@
 import {
+  QueryCache,
   QueryClient,
   QueryClientProvider,
-  QueryCache,
 } from "@tanstack/react-query";
 import { ReactQueryDevtools } from "@tanstack/react-query-devtools";
 import React, { useState } from "react";
@@ -23,6 +23,7 @@ const queryClient = new QueryClient({
     },
   },
   queryCache: new QueryCache({
+    // biome-ignore lint/correctness/noUnusedVariables: ESLint to Biome legacy ignore
     onError: (error, query) => {
       if (query.meta.errorMessage) {
         toastError({

assets/src/scripts/outputs-viewer/__tests__/components/Button/PrepareButton.test.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import userEvent from "@testing-library/user-event";
 import React from "react";
 import { ToastContainer } from "react-toastify";
@@ -79,7 +78,6 @@ describe("<PrepareButton />", () => {
       expect(jsonBody.file_ids).toEqual(fileIds);
 
       return new Promise((resolve) =>
-        // eslint-disable-next-line no-promise-executor-return
         setTimeout(() => {
           const res = { url: urls.redirect };
           return resolve(JSON.stringify(res));

assets/src/scripts/outputs-viewer/__tests__/components/Button/PublishButton.test.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import userEvent from "@testing-library/user-event";
 import React from "react";
 import { ToastContainer } from "react-toastify";
@@ -23,7 +22,6 @@ describe("<PublishButton />", () => {
     fetch.mockResponseOnce(
       () =>
         new Promise((resolve) =>
-          // eslint-disable-next-line no-promise-executor-return
           setTimeout(() => resolve({ body: "ok" }), 100),
         ),
     );

assets/src/scripts/outputs-viewer/__tests__/components/FileList/FileList.test.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console, no-unused-vars, react/prop-types */
 import userEvent from "@testing-library/user-event";
 import React, { useState } from "react";
 import { describe, expect, it, vi } from "vitest";
@@ -11,9 +10,10 @@ import {
   txtFile,
 } from "../../helpers/files";
 import props from "../../helpers/props";
-import { render, screen, waitFor, history } from "../../test-utils";
+import { history, render, screen, waitFor } from "../../test-utils";
 
 function FileListWrapper() {
+  // biome-ignore lint/correctness/noUnusedVariables: ESLint to Biome legacy ignore
   const [listVisible, setListVisible] = useState(true);
   const [_, setSelectedFile] = useState(false);
   return (

assets/src/scripts/outputs-viewer/__tests__/components/Metadata/Metadata.test.jsx

@@ -46,7 +46,6 @@ describe("<Metadata />", () => {
   });
 
   it("shows unknown for file size if file size not provided", () => {
-    // eslint-disable-next-line no-console
     console.error = vi.fn();
 
     render(

assets/src/scripts/outputs-viewer/__tests__/components/Table/Table.test.jsx

@@ -5,6 +5,7 @@ import { csvExample, csvFile } from "../../helpers/files";
 import { render, screen } from "../../test-utils";
 
 describe("<Table />", () => {
+  // biome-ignore lint/style/useConsistentBuiltinInstantiation: ESLint to Biome legacy ignore
   const twoThousandRows = `${Array(2000).fill(`b
   `)}`.trimEnd();
 

assets/src/scripts/outputs-viewer/__tests__/components/Viewer/Viewer.test.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import React from "react";
 import { describe, expect, it, vi } from "vitest";
 import Viewer from "../../../components/Viewer/Viewer";

assets/src/scripts/outputs-viewer/__tests__/test-setup.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies */
 import "@testing-library/jest-dom/vitest";
 import { beforeEach, vi } from "vitest";
 import createFetchMock from "vitest-fetch-mock";

assets/src/scripts/outputs-viewer/__tests__/test-utils.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console, import/no-extraneous-dependencies, react/prop-types */
 import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
 import { render } from "@testing-library/react";
 import { createMemoryHistory } from "history";

assets/src/scripts/outputs-viewer/components/Button/Button.jsx

@@ -45,7 +45,6 @@ function Button({
       `}
       disabled={disabled}
       onClick={onClick}
-      // eslint-disable-next-line react/button-has-type
       type={type}
     >
       {children}

assets/src/scripts/outputs-viewer/components/FileList/FileList.jsx

@@ -20,6 +20,7 @@ function FileList({ authToken, filesUrl, listVisible, setSelectedFile }) {
 
   const listRef = createRef();
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ESLint to Biome legacy ignore
   useEffect(() => {
     const selectedItem = data?.find(
       (file) => `/${file.name}` === location.pathname,
@@ -30,8 +31,6 @@ function FileList({ authToken, filesUrl, listVisible, setSelectedFile }) {
     if (data) {
       setFiles(data);
     }
-
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [isSuccess]);
 
   if (isLoading) {

assets/src/scripts/outputs-viewer/components/FileList/Filter.jsx

@@ -5,14 +5,14 @@ import FormInput from "../Form/Input";
 function Filter({ files, listRef, setFiles }) {
   const [filter, setFilter] = useState("");
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ESLint to Biome legacy ignore
   useEffect(() => {
     const filteredFiles = [...files].map((file) => ({
       ...file,
       visible: file.shortName.toLowerCase().includes(filter.toLowerCase()),
     }));
 
     setFiles(filteredFiles);
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [filter]);
 
   function filterOnChange(e) {

assets/src/scripts/outputs-viewer/components/Iframe/Iframe.jsx

@@ -8,6 +8,7 @@ function Iframe({ data, fileName, fileUrl }) {
   const [frameHeight, setFrameHeight] = useState(0);
   const id = encodeURIComponent(fileUrl).replace(/\W/g, "");
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: ESLint to Biome legacy ignore
   useLayoutEffect(() => {
     const minHeight = 1000;
     if (document.getElementById(id) && window.innerWidth > 991) {

assets/src/scripts/outputs-viewer/components/Table/Table.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable react/no-array-index-key */
 import PropTypes from "prop-types";
 import React from "react";
 import { usePapaParse } from "react-papaparse";
@@ -11,6 +10,7 @@ function TableRow({ row }) {
   return (
     <tr className="divide-x divide-gray-200 even:bg-gray-50">
       {row.map((cell, i) => (
+        // biome-ignore lint/suspicious/noArrayIndexKey: ESLint to Biome legacy ignore
         <TableCell key={i} cell={cell} />
       ))}
     </tr>
@@ -37,6 +37,7 @@ function Table({ data }) {
               <table className="min-w-full divide-y divide-gray-300">
                 <tbody className="divide-y divide-gray-200 bg-white">
                   {jsonData.slice(0, 1000).map((row, i) => (
+                    // biome-ignore lint/suspicious/noArrayIndexKey: ESLint to Biome legacy ignore
                     <TableRow key={i} row={row} />
                   ))}
                 </tbody>
@@ -55,6 +56,7 @@ function Table({ data }) {
           <table className="min-w-full divide-y divide-gray-300">
             <tbody className="divide-y divide-gray-200 bg-white">
               {jsonData.map((row, i) => (
+                // biome-ignore lint/suspicious/noArrayIndexKey: ESLint to Biome legacy ignore
                 <TableRow key={i} row={row} />
               ))}
             </tbody>

assets/src/scripts/outputs-viewer/hooks/use-file-list.js

@@ -8,7 +8,6 @@ function longestSubStr(files) {
     const splitFileName = file.name.split("/");
     if (i === 0) {
       initialStr = [];
-      // eslint-disable-next-line no-return-assign
       return (initialStr = splitFileName);
     }
 

assets/src/scripts/outputs-viewer/hooks/use-window-size.js

@@ -1,5 +1,5 @@
 import debounce from "just-debounce-it";
-import { useState, useEffect } from "react";
+import { useEffect, useState } from "react";
 
 // Hook
 function useWindowSize(delay = 100) {

assets/src/scripts/outputs-viewer/utils/toast.js

@@ -5,7 +5,7 @@ export function toastDismiss({ toastId }) {
 }
 
 export function toastError({ toastId, message, ...args }) {
-  // eslint-disable-next-line no-console
+  // biome-ignore lint/suspicious/noConsole: ESLint to Biome legacy ignore
   console.error(message, { ...args });
 
   toast.error(message, {

assets/src/styles/_datatable.css

@@ -31,10 +31,8 @@
       border-radius: 0.375rem;
       border-color: var(--color-slate-300);
       font-weight: 400;
-      box-shadow:
-        0 0 rgba(0, 0, 0, 0),
-        0 0 rgba(0, 0, 0, 0),
-        0 1px 2px 0 rgba(0, 0, 0, 0.05);
+      box-shadow: 0 0 rgba(0, 0, 0, 0), 0 0 rgba(0, 0, 0, 0), 0 1px 2px 0
+        rgba(0, 0, 0, 0.05);
 
       @media (min-width: 640px) {
         font-size: 0.875rem;