Skip to content

Commit

Permalink
Merge pull request #4701 from opensafely-core/steve/remove-end-to-end…
Browse files Browse the repository at this point in the history
…-test-references

Remove end-to-end test references
  • Loading branch information
StevenMaude authored Oct 23, 2024
2 parents 089628b + 3147b57 commit a831b38
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,11 @@ Tests should be fast where possible.


## Testing Pyramid
Job Server uses a three layer testing pyramid, with the following layers from top to bottom:
* End-to-End
* Integration
* Unit

Below we describe how we draw the lines between each of those layers.

Much like the developer tooling at Bennett Institute for Applied Data Science we define these layers as an ideal guide that should be adhered by default, but in the knowledge that things can deviate if there is a good reason.
Job Server uses a testing pyramid, with the following layers from top to bottom:

* Integration
* Unit

### Unit Tests
**Directory:** `tests/unit`
Expand Down Expand Up @@ -61,14 +57,6 @@ Ideally these tests would avoid mocking.
This lets us test views with all the surrounding parts turned: URL routing, middleware, etc.


### End-to-End
**Directory:** `tests/e2e`

We don't currently have any end-to-end tests but with the upcoming addition of onboarding it's clear we need a way to test across multiple views.

The expectation is that these tests will check user flows work as expected, eg "As a user who has not signed up before who has received an invite email I can…". These tests would likely like Client instances.


## Tooling
We use [coverage.py](https://coverage.readthedocs.io/) to check test coverage on the code base and require 100% coverage for CI to pass.

Expand Down
Empty file removed tests/e2e/__init__.py
Empty file.

0 comments on commit a831b38

Please sign in to comment.