Fix add_job cli command #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodearnest
force-pushed
the
fix-add-job
branch
from
88c435e to
bc17b54
Compare
rebkwok
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Changes look fine to me, but it would probably be a good idea to add a test for this, since it's still not covered. I added the new codelists check flag that broke this, and I don;t think there's anything here that would prevent that happening again in future
This was not previously covered in tests, and it broke with the codelist checking changes. It's used in the backed-server test suite, which is how I noticed. If fixed, and added test coverage, which allowed me to bump the coverge minimum a bit.
bloodearnest
force-pushed
the
fix-add-job
branch
from
bc17b54 to
71d6b40
Compare
Indeed, I started with such a test, but forgot to include it in the PR 🤦 |
rebkwok
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not previously covered in tests, and it broke with the codelist
checking changes. It's used in the backed-server test suite, which is
how I noticed.
If fixed, and added test coverage, which allowed me to bump the coverge
minimum a bit.