Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand and support use-cases for in-place notebooks edits #155

Closed
Tracked by #406
wjchulme opened this issue Jan 22, 2021 · 5 comments
Closed
Tracked by #406

Understand and support use-cases for in-place notebooks edits #155

wjchulme opened this issue Jan 22, 2021 · 5 comments
Assignees

Comments

@wjchulme
Copy link

Due to the way the job-runner manages files, it's not currently possible to execute and save a .ipynb notebook, unless you save it as something else (either a different name, file location, or file type).

So you either have to save it to a different location and then run another action to put it back (using file system operations in R, say), or execute manually on the server.

@bloodearnest bloodearnest self-assigned this Jan 25, 2021
@HelenCEBM
Copy link

I think this will be useful for various updating reports because currently, making a small change in the text that doesn't affect the results requires many steps (update locally, push to branch, merge, submit to job runner, wait, log in to server, copy and check files for release, push to new branch, merge again). It would be great if this kind of small change could just be the first 3 of these steps!

@bloodearnest
Copy link
Member

Trying a manual tag: @brianmackenna

@iaindillingham iaindillingham changed the title executing and saving a notebook using project.yaml Allow notebook files to be edited in-place Apr 19, 2022
@iaindillingham
Copy link
Member

Summary of the issue:

  • For an in-place edit, the notebook file must be copied into and out of the container.
  • For the notebook file to be copied out of the container, it must be listed in outputs.
  • However, if the notebook file is listed in outputs, then it is not copied into the container.

A workaround is to save the edited notebook file to a new location, which is listed in outputs, and then overwrite the original notebook file with the edited notebook file in a subsequent action.

@evansd
Copy link
Contributor

evansd commented Apr 19, 2022

We're going to have to come up with an alternative workflow here as all the workarounds are essentially just exploiting bugs in job-runner which will fix at some point.

I think what we need to do is:

  • collect a series of use-cases where people want to be able to do in-place updates, and their reasons for wanting to do so;
  • work out the "correct" workflow for handling these;
  • create the documentation and/or tooling needed to make these workflows easy for users.

@sebbacon sebbacon changed the title Allow notebook files to be edited in-place Understand as support use-cases for in-place notebooks edits May 16, 2022
@benbc benbc changed the title Understand as support use-cases for in-place notebooks edits Understand and support use-cases for in-place notebooks edits Jun 22, 2022
@benbc
Copy link
Contributor

benbc commented Jun 23, 2022

Closing in favour of this option in our pipeline.

@benbc benbc closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants