Draw the owl #1679
Merged
Draw the owl #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub have updated their UI, so we should update the screenshots.
We shouldn't insist that the reader completes the tutorial twice, so we remove the "first time" and "second time" call-outs and, by doing so, decouple the dataset definition sections.
The "Writing a more complex dataset definition" section breaks the flow of the tutorial, so we move it down the TOC.
Here, we tweak some formatting to make it consistent with [the GitHub docs style guide][1]. Whilst many style guides are available, this style guide is easy to access and familiar. [1]: https://docs.github.com/en/contributing/style-guide-and-content-model/style-guide
inglesp
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Does this belong in an ehrQL tutorial?
There was a problem hiding this comment.
Yes. I'm open to a different perspective, but it would have been better to raise it on #1633, which has a section entitled Commit the dataset definition to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1655, this helps the reader draw the owl. Specifically:
The remaining commits are updates, improvements, and tweaks that would seem out of context in a separate PR.
🦉
Closes #1633