Skip to content

Commit

Permalink
Merge pull request #1035 from opensafely-core/evansd/docker-compose-fix
Browse files Browse the repository at this point in the history
Update to Docker Compose v2 syntax
  • Loading branch information
evansd authored Aug 2, 2024
2 parents f07867c + 10eeacd commit 51c9e7e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test_runner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
touch requirements.*.txt
make devenv
- name: Start SQL Server and Trino instances for the tests
run: docker-compose up -d mssql trino
run: docker compose up -d mssql trino
- name: Run tests
run: |
source ${{ github.workspace }}/venv/bin/activate
Expand All @@ -56,9 +56,9 @@ jobs:
- name: Build docker
run: make docker-build ENV=dev
- name: Basic docker test
run: docker-compose run --rm -v $PWD:/workspace dev cohortextractor
run: docker compose run --rm -v $PWD:/workspace dev cohortextractor
- name: Run unit tests in docker
run: docker-compose run --rm -v $PWD:/workspace dev pytest
run: docker compose run --rm -v $PWD:/workspace dev pytest

build:
name: Test we can build PyPI package
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ docker-build: export VERSION=$(shell git describe --tags)
docker-build: export DOCKER_BUILDKIT=1
docker-build: ENV=dev
docker-build:
docker-compose build --pull $(ARGS) $(ENV)
docker compose build --pull $(ARGS) $(ENV)



Expand Down

0 comments on commit 51c9e7e

Please sign in to comment.