Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent GHA from timing out after 3mo #26

Open
madwort opened this issue Aug 18, 2023 · 4 comments · Fixed by #27
Open

Prevent GHA from timing out after 3mo #26

madwort opened this issue Aug 18, 2023 · 4 comments · Fixed by #27
Assignees
@madwort
Labels
security

Comments

@madwort
Copy link
Contributor

madwort commented Aug 18, 2023 •
edited
Loading

  • We believe Github Actions stops running scheduled actions after 3mo if there are no new commits to the repo.
  • We believe that if we keep an automated record of the current sha of the ubuntu base images in the git repo, we can ensure that GHA keeps running, and we keep receiving security updates.
  • see discussion at https://bennettoxford.slack.com/archives/C03ELD5FEAU/p1692357344762739
@lucyb lucyb added the security label Aug 23, 2023
@madwort madwort mentioned this issue Sep 25, 2023
Merged
@madwort
Copy link
Contributor Author

madwort commented Sep 25, 2023

#26

@madwort
Copy link
Contributor Author

madwort commented Sep 27, 2023 •
edited
Loading

new plan - #30 - unfinished, as I need to figure out how to get dependabot to do the right thing

EDIT: abandoned due to complications.

@bloodearnest bloodearnest removed their assignment Oct 2, 2023
@madwort
Copy link
Contributor Author

madwort commented Oct 11, 2023

dargh not fixed, update to follow

@madwort madwort reopened this Oct 11, 2023
@madwort
Copy link
Contributor Author

madwort commented Oct 11, 2023

So I'm an idiot, and hadn't taken into account that because main is a protected branch that requires an approval review to merge we can't just push to main from the scheduled task. So, if we want auto-merge we need the PR to be created by a different actor to the PR reviewer, which means PR created by dependabot & auto-merged by actionrunner.

The good news is that the hashes that dependabot is using when updating a Dockerfile now match what I expected to see. So I now think that the sha mismatch was due to version skew rather than a different package. citation actions/runner-images@cb9fe37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madwort madwort

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add GHA workflow to keep track of the Ubuntu image SHA opensafely-core/base-docker
3 participants
@bloodearnest @madwort @lucyb