Validate config with jsonschema
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we setup logging as soon as reasonably possible.
Doing so allows us to add more complex configuration in the future e.g. nested data structure; and allows us to validate types.
The latter displays a nicely formatted error message. Hat-tip to @ccunningham101, who I saw using this recently.
ccunningham101
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from a couple of small enhancements, in this PR we replace the simple "are the observed keys the expected keys" approach to validation with
jsonschema. This allows us to add more complex configuration in the future, which is discussed in #4 and #18. It also allows us to validate types, meaning that this will no longer pass validation: