Specify an input glob pattern #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_parse_args` test is broken because it doesn't contain any assert statements.
This replaces the `--input-dir` argument with the `--input-files` argument. Whereas the former accepts a path to a directory, the latter accepts a glob pattern. This commit addresses the substantive issue, but some tidying up would be worthwhile. Closes #7
Here, this means all paths from args are now resolved (i.e. made absolute).
We can remove `test_input_table`, because `test_measure_table` now tests that other CSVs (either weekly/monthly CSVs or CSVs containing input tables) are filtered.
As @inglesp pointed out, the call to `next` is distracting. If we want to advance the generator function, then we can instead call `list`. As a bonus, calling `list` exhausts the generator function, so we can assert that the expected number of measure tables have been returned.
ccunningham101
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to specify an input glob pattern, rather than an input path, allowing deciles-charts to read a subset of the measure tables.
94e233e addresses the substantive issue; the other commits either fix a broken test 😳 or tidy up.
Closes #7