Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose show_outer_percentiles arg #21

Closed
LFISHER7 opened this issue Apr 19, 2022 · 2 comments · Fixed by #24
Closed

Expose show_outer_percentiles arg #21

LFISHER7 opened this issue Apr 19, 2022 · 2 comments · Fixed by #24
Assignees
@iaindillingham @LFISHER7

Comments

@LFISHER7
Copy link
Contributor

LFISHER7 commented Apr 19, 2022 •
edited
Loading

The default behaviour is for the outer percentiles (1-9, 91-99) to be plotted.

Often, this detail isn't needed and makes the charts noisy, so we just plot the deciles E.g SRO-report

It would be useful to expose the show_outer_percentiles argument here when specifying the action.
@LFISHER7 LFISHER7 self-assigned this Apr 19, 2022
@LFISHER7 LFISHER7 mentioned this issue Apr 19, 2022
Closed
@iaindillingham
Copy link
Member

Do I need to be logged into the reports site to follow those links, @LFISHER7? (They're 404ing for me.)

I've made a comment on the associated PR that I could equally have made here. Essentially, it's preferable to pass options through the config key, rather than through arguments. Could you consider what we'd like the config key to look like?

@LFISHER7
Copy link
Contributor Author

Ah you do, there's an example figure below from the first link, and the second link was wrong! (now updated)

Screenshot 2022-04-19 at 17 59 42

Sorry to have forgotten about the existence of config and glossed over #4 . I'll have a think of how we can incorporate this with the existing suggestions

iaindillingham added a commit that referenced this issue Apr 20, 2022
@iaindillingham
Expose show_outer_percentiles arg
77c0d16 
To expose this arg, we add the mechanism for reading JSON-encoded
configuration, which we expect to be passed by job-runner. As such, we
don't check that the JSON is valid. However, we do check that the
configuration keys are correct, and report any incorrect configuration
keys (e.g. typos) to the user. We don't check the configuration values
are correct; doing so would require more complex code, which is probably
unnecessary.

We should still consider what we'd like the `config` key to look like.
However, we can iterate on that problem as we add more configuration.

Closes #21
@iaindillingham iaindillingham mentioned this issue Apr 20, 2022
Merged
@iaindillingham iaindillingham changed the title Expose show_outer_percentiles arg Expose show_outer_percentiles arg Apr 21, 2022
@iaindillingham iaindillingham self-assigned this Apr 21, 2022
@iaindillingham iaindillingham mentioned this issue Apr 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iaindillingham iaindillingham

@LFISHER7 LFISHER7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose show_outer_percentiles arg opensafely-actions/deciles-charts
2 participants
@iaindillingham @LFISHER7