Cleanups and enable MMU test #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olofk
reviewed
Oct 13, 2020
native/or1200/or1200-cbasic.c
Outdated
| @@ -1,6 +1,7 @@ | |||
| /* Test basic c functionality, and BSS section clearing. */ | |||
| #include "cpu-utils.h" | |||
| #include "lib-utils.h" | |||
| //#include "cpu-utils.h" | |||
There was a problem hiding this comment.
Remove the commented lines completely perhaps?
There was a problem hiding this comment.
Yes, I will. This old code is pretty messy. Once it's all working I'll do a once over cleanup.
Thanks for having a look. There is more to come for the mmu test which is still broken.
|
I took a quick look, and other than a couple of commented lines I couldn't find anything controversial so I trust you got this right |
|
Note, I started working on this cleanup a while back and stopped. Now I need to test traps on mor1kx as I suspect a bug is causing the debugger to fall. It may be fixed by this pr but I need a test bench to be sure. |
|
ok I messed up merging this. Fixed it manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various whitespace and duplicate code cleanups.
Fix the Makefile so it actually tracks dependencies.
The MMU test seems completely broken