Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report tests in TAP format #5

Merged
merged 2 commits into from
Aug 3, 2019
Merged

Report tests in TAP format #5

merged 2 commits into from
Aug 3, 2019

Conversation

Nancy-Chauhan
Copy link
Contributor

@Nancy-Chauhan Nancy-Chauhan commented Aug 2, 2019 •
edited
Loading

Create a new report.tap with test results written in TAP format
@stffrdhrn @oleg-nenashev

@Nancy-Chauhan
Report tests in TAP format
2b72e1c 
Create a new report.tap with test results written in TAP format
stffrdhrn
stffrdhrn approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@stffrdhrn stffrdhrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@stffrdhrn
Copy link
Member

Why is it a draft? Looks ok to me

oleg-nenashev
oleg-nenashev approved these changes Aug 2, 2019
View reviewed changes
Copy link

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it works

@Nancy-Chauhan
Copy link
Contributor Author

Nancy-Chauhan commented Aug 2, 2019 •
edited
Loading

@stffrdhrn Please confirm if this looks okay to you for output in .tap format?

PASS >> ok
UNEXPECTED PASS >> not ok
TIME OUT >> not ok
UNEXPECTED FAIL >> not ok
FAIL >> not ok

Then I will do changes in Jenkinsfile

@Nancy-Chauhan Nancy-Chauhan marked this pull request as ready for review August 2, 2019 10:31
stffrdhrn
stffrdhrn requested changes Aug 2, 2019
View reviewed changes
Copy link
Member

@stffrdhrn stffrdhrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok except one point

native/runtests.sh Outdated Show resolved Hide resolved
@stffrdhrn
Copy link
Member

I don't quite understand your comment. But fail is actually ok.

@Nancy-Chauhan
Copy link
Contributor Author

Nancy-Chauhan commented Aug 3, 2019 •
edited
Loading

@stffrdhrn Does it look fine now? I will do changes in Jenkinsfile then once it is merged

@stffrdhrn stffrdhrn merged commit 7372eae into openrisc:master Aug 3, 2019
@Nancy-Chauhan Nancy-Chauhan mentioned this pull request Aug 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@stffrdhrn stffrdhrn stffrdhrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nancy-Chauhan @stffrdhrn @oleg-nenashev