Check that we have downloaded the file successfully #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are downloading files we should check that the http call was successful instead of assuming that because no exception was thrown that the http status was successful. In the case were we get a 408, we don't throw an exception. This results in a InputStream of null to be returned. When reading from a InputStream of null, it infinitely returns a list of null bytes. In our use case we end up writing null to a temporary file until we run out of disk space We can also make this change in the `HttpSender` and throw when we get a none successful http code
natedanner
approved these changes
Oct 29, 2024
timtebeek
reviewed
Oct 29, 2024
rewrite-core/src/test/java/org/openrewrite/remote/RemoteArchiveTest.java
Outdated
Show resolved
Hide resolved
sambsnyd
reviewed
Oct 29, 2024
|
I'm also going to update the test to each have their own cache, because at the moment only the 1st test running the expect logic while the others are falling back to the cache and aren't testing the expected logic |
zieka
reviewed
Oct 29, 2024
| @@ -93,7 +93,11 @@ public InputStream getInputStream(ExecutionContext ctx) { | |||
| Path localArchive = cache.compute(uri, () -> { | |||
| //noinspection resource | |||
| HttpSender.Response response = httpSender.send(httpSender.get(uri.toString()).build()); | |||
| return response.getBody(); | |||
| if (response.isSuccessful()) { | |||
There was a problem hiding this comment.
question to team:
should we be doing some type of retry here to improve reliability with transient errors like network glitch or delays?
There was a problem hiding this comment.
If want to implement retires, I think we might want to move this change to the HttpSender, I suspect other endpoints could benefit from it
sjungling
approved these changes
Oct 30, 2024
timtebeek
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are downloading files we should check that the http call was successful instead of assuming that because no exception was thrown that the http status was successful. In the case were we get a 408, we don't throw an exception. This results in a InputStream of null to be returned. When reading from a InputStream of null, it infinitely returns a list of null bytes. In our use case we end up writing null to a temporary file until we run out of disk space
We can also make this change in the
HttpSenderand throw when we get a none successful http code