Comments cannot be parsed properly

[Laurens-W]

What's changed?

Identified a setup of comments that doesn't get parsed properly and added that as reproducer testcase

• Fixes rewrite-java - Parser issue with consecutive comment blocks #4344

Anyone you would like to review specifically?

@nielsdebruin @timtebeek

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[Laurens-W]

Looks like the issue is related to the ending */ and beginning /* delimiters being on the same line

[nielsdebruin]

With @Laurens-W, I looked at and debugged the code. In the end, we found that removing the +2 increment (see commit) resolves the issue. However, we are uncertain what the original reasoning behind this +2 instead of +1 increment was.

[timtebeek]

@nielsdebruin thanks for diving in! This seems to have resulted in some new failures in methodWithSuffixMultiComment().
https://ge.openrewrite.org/s/2h7bdj253sf7m/tests/overview?outcome=FAILED

diff --git a/Test.java b/Test.java	
index 5d28d39..c911b87 100644	
--- a/Test.java	
+++ b/Test.java	
@@ -1,3 +1,3 @@ 	
 class Test {	
-    public void foo() { }/*Comments*/	
+    public void foo() { }///Comments*/	
 }	
\ No newline at end of file	

Would you mind having a look at those?

[timtebeek]

Great to see you've worked out a way to get the test going; From my local tests it seems the continue isn't necessary, and we can instead evaluate the if (!inMultiLineComment && !inSingleLineComment) below like normal. Would you agree? Or is there a failing scenario we can code up where that would not work?