Backport DocCommentTree reflection to ReloadableJava17ParserVisitor #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
reviewed
Oct 27, 2024
Yeah on a Sunday there's no work getting in the way. ;) |
|
Tested the latest SNAPSHOT using JDK 23.0.1 against Error Prone Support, and can confirm that this fixes the issue 👍. Tnx again for the quick turnaround! |
|
Great to hear and thanks for testing out the snapshot version; we'll likely do a .patch release tomorrow if a belated review does not turn up anything alarming. I did already release rewrite-templating that might be good to fold into EPS ahead of a release: https://github.com/openrewrite/rewrite-templating/releases/tag/v1.16.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Backport the changes from the Java 23 support in our Java 21 parser to our Java 17 parser:
What's your motivation?
As requested via links below, and helpful for folks that only have rewrite-java-17 on their classpath still.
Anyone you would like to review specifically?
@Stephan202
Any additional context