Simplify constant ternary expressions too #4617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
timtebeek
added a commit
to JLLeitschuh/rewrite-static-analysis
that referenced
this pull request
Oct 27, 2024
timtebeek
added a commit
to openrewrite/rewrite-static-analysis
that referenced
this pull request
Oct 27, 2024
* Add Two Recipes - BufferedWriterCreation - SimplifyConstantTernaryExecution Signed-off-by: Jonathan Leitschuh <[email protected]> * Apply auto formatting to owning LST element * Apply formatter and best practices * Drop unnecessary UsesType * Minor polish * Drop now unnecessary SimplifyConstantTernaryExecution Following openrewrite/rewrite#4617 * Restore private `cleanupBooleanExpression` * Convert to regular Refaster recipe Following openrewrite/rewrite-templating#114 --------- Signed-off-by: Jonathan Leitschuh <[email protected]> Co-authored-by: Knut Wannheden <[email protected]> Co-authored-by: Tim te Beek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Expand
SimplifyBooleanExpressionVisitorto also clear out ternary expressions with a hardcoded true/falseWhat's your motivation?
BufferedWriterCreationrecipe rewrite-static-analysis#258Anything in particular you'd like reviewers to focus on?
Didn't want to duplicate or recurse too much for parentheses, instead assuming this is often combined with remove unnecessary parentheses already.