Add visitModifier() to base JavaVisitor
#4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,14 +66,15 @@ public TreeVisitor<?, ExecutionContext> getVisitor() { | |||
| } | |||
|
|
|||
| @Override | |||
| protected void visitModifier(J.Modifier modifier, PrintOutputCapture<ExecutionContext> p) { | |||
| public J visitModifier(J.Modifier modifier, PrintOutputCapture<ExecutionContext> p) { | |||
There was a problem hiding this comment.
I suspect that this method can now probably be entirely removed, as it will be covered by the visit() method now.
|
Thanks @macsux ! |
knutwannheden
changed the title
visitModifier() to base JavaVisitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Allows
ModifierLST to be visitedWhat's your motivation?
Consistency and resolve issues with remoting to other langugages