Actually support Recipe in addApplicableTest & addSingleSourceApplicableTest
#2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLLeitschuh
commented
Feb 17, 2023
Comment on lines
-139
to
-144
| static List<Result> createAndProcessResults( | ||
| List<? extends SourceFile> before, | ||
| List<? extends SourceFile> after, | ||
| ExecutionContext ctx, | ||
| Map<UUID, Stack<Recipe>> recipeThatAddedOrDeletedSourceFile | ||
| ) { |
There was a problem hiding this comment.
Moved into RecipeSchedulerUtil but otherwise unchanged IIRC
JLLeitschuh
force-pushed
the
feat/JLL/full-visitors-as-applicability-tests
branch
4 times, most recently
from
fe993b5
to
6a5c70d
Compare
JLLeitschuh
commented
Feb 21, 2023
Comment on lines
+562
to
+570
| for (S newS : next) { | ||
| newS.getMarkers().findFirst(Markup.Error.class).ifPresent(m -> { | ||
| if (m.getException() instanceof RecipeRunException) { | ||
| throw (RecipeRunException) m.getException(); | ||
| } else { | ||
| throw new RuntimeException("Applicable Test Failed", m.getException()); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
@jkschneider is there a better/more appropriate way to do this?
JLLeitschuh
force-pushed
the
feat/JLL/full-visitors-as-applicability-tests
branch
from
6a5c70d
to
efdd3db
Compare
…plicableTest` Recipes used in applicability tests will have their own applicabibility tests invoked now. This means that expensive recipes with light `singleSourceApplicableTest` can be used without incurring a performance overhead of invoking the recipe visitor every time.
JLLeitschuh
force-pushed
the
feat/JLL/full-visitors-as-applicability-tests
branch
from
efdd3db
to
9983adc
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recipes used in applicability tests will have their own applicability tests invoked now.
This means that expensive recipes with light
singleSourceApplicableTestcan be used without incurring a performance overhead of invoking the recipe visitor every time.