Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[660] Use the correct implementation of the MethodOrderer for the @Te… #661

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

jamezp
Copy link
Contributor

@jamezp jamezp commented Jan 3, 2025

…stMethodOrder annotation.

resolves #660

What's changed?

Changed the value for the @TestMethodOrder class to MethodOrderer.OrderAnnotation.class when migrating Arquillian JUnit 4 tests to JUnit 5 that use the @InSequence annotation.

What's your motivation?

The current value, MethodOrderer.class, is an interface and cannot be instantiated.

Have you considered any alternatives or workarounds?

The only workaround is to simply manually change the annotation value.

Any additional context

N/A

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

…stMethodOrder annotation.

Signed-off-by: James R. Perkins <[email protected]>
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@timtebeek timtebeek merged commit a4a0e11 into openrewrite:main Jan 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wrong MethodOrderer used when replacing the Arquillian @InSequence annotations
2 participants