Add Kotlin support for Junit 5 recipes 1: CleanupJUnitImports #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Some of the recipes were not working with Kotlin code bases, i would like to add this one as a first example and will change the rest of the recipes the same way after the feedback. More MRs to follow.
The change is around the usage of visitCompilationUnit, this visitor doesn't work with Kotlin codebases , i made the change to use preVisit, and this seems to fix it.
What's your motivation?
we would like to make the recipes work on Kotlin codebases
Anything in particular you'd like reviewers to focus on?
Please let me know if this is the correct way, especially to add tests for both Kotlin and Java together like the way I have done.
Anyone you would like to review specifically?
@timtebeek @knutwannheden
Have you considered any alternatives or workarounds?
Nope
Any additional context
Checklist