support for allOf
hamcrest matcher
#396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR modifies the
HamcrestAnyOfToAssertJ
recipe to add support for theallOf
matcher as well. The recipe name will probably need to be changed if this PR is merged. I suggest maybe something likeHamcrestOfMatchersToAssertJ
.What's your motivation?
#357
Anything in particular you'd like reviewers to focus on?
I was wondering if maybe we could also add some sort of support for the
allOf(Iterable)
andanyOf(Iterable)
methods. I don't think it would work for every case but for cases where maybe you have anIterable
directly passed in likeArrays.asList(...)
. We could probably do the same thing we would just have to extract the arguments of theasList
method invocation.Anyone you would like to review specifically?
@timtebeek
Checklist
./gradlew licenseFormat