Test to ParameterizedTest annotation #349
Conversation
…esn't return true when getting to ValueSource annotations
| public void defaults(RecipeSpec spec) { | ||
| spec | ||
| .parser(JavaParser.fromJavaVersion() | ||
| .classpathFromResources(new InMemoryExecutionContext(), "junit-4.13", "junit-jupiter-api-5.9")) |
There was a problem hiding this comment.
We're only using JUnit Jupiter here, so there's no need for the JUnit 4 dependency.
| .classpathFromResources(new InMemoryExecutionContext(), "junit-4.13", "junit-jupiter-api-5.9")) | |
| .classpathFromResources(new InMemoryExecutionContext(), "junit-jupiter-api-5.9")) |
| rewriteRun( | ||
| java( | ||
| """ | ||
| @Test |
There was a problem hiding this comment.
This test is lacking imports, and thus likely to have missing types, and through that failing matchers.
Same goes for the tests below.
There was a problem hiding this comment.
It might help to check that the code snippets that you use in a text block are actually valid stand alone classes, by briefly copy-pasting these into a new file. Your IDE will then immediately tell you if you're missing imports for instance.
There was a problem hiding this comment.
Ya I was planning on updating those once I got the first test working, but I'll update them now.
|
|
||
| public class AddParameterizedTestAnnotation extends Recipe { | ||
| private static final AnnotationMatcher TEST_ANNOTATION_MATCHER = new AnnotationMatcher("@org.junit.jupiter.api.Test"); | ||
| private static final AnnotationMatcher VALUE_SOURCE_ANNOTATION_MATCHER = new AnnotationMatcher("@org.junit.jupiter.params.provider.ValueSource"); |
There was a problem hiding this comment.
Had you noticed that this matcher takes in a pattern that can include parameters as well? That might be why your matcher fails. Perhaps something to trace with the debugger.
There was a problem hiding this comment.
How should I update the pattern? I kinda know what needs to be added but I'm not sure how to do it in a way thats generic enough? Would something like ValueSource("#{}") work?
There was a problem hiding this comment.
Maybe ValueSource(..) in case it's in line with our other matchers? I'd tried to look for examples, but I'm not finding a lot: https://public.moderne.io/results/1SllD
…hrough that instead of individually visiting Annotations
…array, ValueSource annotation matcher not returning true when it finds a ValueSource annotation
…AddImport() and .imports()
…AddImport() and .imports()
|
Superseeded by #353 |
What's changed?
This draft PR adds a new recipe which adds missing ParameterizedTest annotations when ValueSource is used or replaces Test with ParameterizedTest.
What's your motivation?
#314
Anything in particular you'd like reviewers to focus on?
For some reason whenever the visitor gets to the ValueSource annotation the ValueSource AnnotationMatcher check does not return true. I was having a similar issue with the Test annotation but that was because I wasn't including junit and jupiter resources in the recipe spec. ValueSource is from jupiter so I don't think its the same issue now that I have included those resources in the spec.
Anyone you would like to review specifically?
@timtebeek