Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JUnit ThrowingRunnableToExecutable recipe #337

Merged

Conversation

peter-janssen
Copy link
Contributor

Recently migrated using openrewrite and was missing this recipe. Possibly not as simple as a ChangeType recipe.

@knutwannheden knutwannheden added the recipe Recipe request label May 14, 2023
Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@knutwannheden knutwannheden merged commit 6225d68 into openrewrite:main May 14, 2023
timtebeek added a commit that referenced this pull request May 14, 2023
To prevent propagation of undesirable patterns with the addition of new tests, as seen in #337
@peter-janssen peter-janssen deleted the throwing-runnable-to-executable branch May 16, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants