Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop SummaryPrinter #264 #266

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Drop SummaryPrinter #264 #266

merged 2 commits into from
Oct 10, 2022

Conversation

timtebeek
Copy link
Contributor

@mpkorstanje do you agree with the samples & replacements here? Should we cover any other cases?
The deprecation notes mentioned EventListeners, but might require further changes.

mpkorstanje
mpkorstanje approved these changes Oct 10, 2022
View reviewed changes
Copy link

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacements look good to me.

pway99
pway99 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@pway99 pway99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timtebeek

@pway99 pway99 merged commit b6f389e into openrewrite:main Oct 10, 2022
@timtebeek timtebeek deleted the drop_SummaryPrinter branch October 10, 2022 16:17
@tkvangorder tkvangorder added the recipe Recipe request label Oct 11, 2022
@tkvangorder tkvangorder added this to the 1.29.0 milestone Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pway99 pway99 pway99 approved these changes

@mpkorstanje mpkorstanje mpkorstanje approved these changes

Assignees
No one assigned
Labels
recipe Recipe request
Projects
OpenRewrite
Archived in project
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timtebeek @mpkorstanje @pway99 @tkvangorder