feat: Add recipes for negative variants of startsWith, endsWith, and …

…matches (#594)
openrewrite · Sep 7, 2024 · 5c23f07 · 5c23f07
1 parent 541e480
commit 5c23f07
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/main/resources/META-INF/rewrite/assertj.yml b/src/main/resources/META-INF/rewrite/assertj.yml
@@ -110,16 +110,31 @@ recipeList:
       assertToReplace: isTrue
       dedicatedAssertion: startsWith
       requiredType: java.lang.String
+  - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertion:
+      chainedAssertion: startsWith
+      assertToReplace: isFalse
+      dedicatedAssertion: doesNotStartWith
+      requiredType: java.lang.String
   - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertion:
       chainedAssertion: endsWith
       assertToReplace: isTrue
       dedicatedAssertion: endsWith
       requiredType: java.lang.String
+  - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertion:
+      chainedAssertion: endsWith
+      assertToReplace: isFalse
+      dedicatedAssertion: doesNotEndWith
+      requiredType: java.lang.String
   - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertion:
       chainedAssertion: matches
       assertToReplace: isTrue
       dedicatedAssertion: matches
       requiredType: java.lang.String
+  - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertion:
+      chainedAssertion: matches
+      assertToReplace: isFalse
+      dedicatedAssertion: doesNotMatch
+      requiredType: java.lang.String
   - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertion:
       chainedAssertion: trim
       assertToReplace: isEmpty

diff --git a/src/test/java/org/openrewrite/java/testing/assertj/SimplifyChainedAssertJAssertionsTest.java b/src/test/java/org/openrewrite/java/testing/assertj/SimplifyChainedAssertJAssertionsTest.java
@@ -85,8 +85,11 @@ private static Stream<Arguments> stringReplacements() {
               Arguments.arguments("equalsIgnoreCase", "isTrue", "isEqualToIgnoringCase", "expected", ""),
               Arguments.arguments("contains", "isTrue", "contains", "expected", ""),
               Arguments.arguments("startsWith", "isTrue", "startsWith", "expected", ""),
+              Arguments.arguments("startsWith", "isFalse", "doesNotStartWith", "expected", ""),
               Arguments.arguments("endsWith", "isTrue", "endsWith", "expected", ""),
+              Arguments.arguments("endsWith", "isFalse", "doesNotEndWith", "expected", ""),
               Arguments.arguments("matches", "isTrue", "matches", "expected", ""),
+              Arguments.arguments("matches", "isFalse", "doesNotMatch", "expected", ""),
               Arguments.arguments("trim", "isEmpty", "isBlank", "", ""),
               Arguments.arguments("length", "isEqualTo", "hasSize", "", "length"),
               Arguments.arguments("isEmpty", "isFalse", "isNotEmpty", "", "")