Support fluent chains in RemoveMethodCallVisitor

[mbruggmann]

What's changed?

RemoveMethodCallVisitor can now remove method invocations in a fluent chain, assuming that the select is also a method invocation and of the same return type. In particular, this works for the builder pattern.

What's your motivation?

• Fixes RemoveMethodCallVisitor doesn't work in fluent APIs #339

Anything in particular you'd like reviewers to focus on?

Is partial support for this use-case worth the added complexity?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/staticanalysis/RemoveMethodCallVisitor.java
  • lines 25-25

[timtebeek]

Thanks for the measured improvement here! Indeed would say that this is worthwhile to add into the visitor. Could you let me know when you're ready for review?

[mbruggmann]

@timtebeek Cool. Feel free to have a look, I was just waiting for the tests to go through in CI.

[timtebeek]

Thanks for the controlled extension to what the visitor can cover! I've added some small polishing commits, but other than that good to go.