Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Removing comments attached to next statement (or end of enclosing class) when removing a variable declarations, that "belongs" to our statement because it has no new line between the statement and the comment.
What's your motivation?
When removing unused private fields, the comment seems to get "attached" to the previous statement.
Closes https://github.com/moderneinc/support-app/issues/15
Anything in particular you'd like reviewers to focus on?
Corner cases not taken into consideration where we should not remove the comment
Anyone you would like to review specifically?
@knutwannheden @timtebeek
Have you considered any alternatives or workarounds?
Maybe getting the next statement with cursors instead of storing it in a structure when traversing the list
Checklist
./gradlew licenseFormat