Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FinalizeMethodArguments considers unary and += expressions #180

Merged
merged 6 commits into from
Oct 2, 2023
Merged

fix: FinalizeMethodArguments considers unary and += expressions #180

merged 6 commits into from
Oct 2, 2023

Conversation

AlejandroBertolo
Copy link
Contributor

What's changed?

closes #176

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

No other workaround was found.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • no new source files were added.
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor

Thanks a lot for getting this fix in so quickly @AlejandroBertolo ! Really appreciate you helping out after reporting #176 yourself too.

@AlejandroBertolo
Copy link
Contributor Author

Thanks a lot for getting this fix in so quickly @AlejandroBertolo ! Really appreciate you helping out after reporting #176 yourself too.

np, just let me know if there is something I need to change to pass the build check.

@timtebeek
Copy link
Contributor

Hmm not that seems to have started failing last night already; not yet clear why:
https://ge.openrewrite.org/s/ahcgfmtgxl53w/tests/overview?outcome=FAILED
I'll try to get it sorted and only then merge your PR such that you don't get pinged.

@timtebeek timtebeek merged commit c41a24a into openrewrite:main Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

FinalizeMethodArguments should consider unary increments/decrements
2 participants