do not remove try block if there are resources

src/main/java/org/openrewrite/staticanalysis/EmptyBlockVisitor.java

@@ -18,16 +18,14 @@
 import lombok.EqualsAndHashCode;
 import lombok.Value;
 import org.openrewrite.internal.ListUtils;
+import org.openrewrite.internal.lang.Nullable;
 import org.openrewrite.java.DeleteStatement;
 import org.openrewrite.java.JavaIsoVisitor;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.JavaVisitor;
 import org.openrewrite.java.format.ShiftFormat;
 import org.openrewrite.java.style.EmptyBlockStyle;
-import org.openrewrite.java.tree.Expression;
-import org.openrewrite.java.tree.J;
-import org.openrewrite.java.tree.Space;
-import org.openrewrite.java.tree.Statement;
+import org.openrewrite.java.tree.*;
 import org.openrewrite.marker.Markers;
 
 import java.util.ArrayList;
@@ -99,7 +97,7 @@ public J.Try visitTry(J.Try tryable, P p) {
 
         if (Boolean.TRUE.equals(emptyBlockStyle.getLiteralTry()) &&
             isEmptyBlock(t.getBody()) &&
-            (t.getResources() == null || t.getResources().isEmpty())) {
+            isEmptyResources(t.getResources())) {
             doAfterVisit(new DeleteStatement<>(tryable));
         } else if (Boolean.TRUE.equals(emptyBlockStyle.getLiteralFinally()) && t.getFinally() != null
                    && !t.getCatches().isEmpty() && isEmptyBlock(t.getFinally())) {
@@ -223,6 +221,29 @@ private boolean isEmptyBlock(Statement blockNode) {
         return false;
     }
 
+    private boolean isEmptyResources(@Nullable List<J.Try.Resource> resources) {
+        if (resources == null || resources.isEmpty()) {
+            return true;
+        }
+        // Searching for access to instances from outside the scope to detect potential side effects.
+        // If that's the case, we cannot remove this resources block.
+        for (J.Try.Resource resource : resources) {
+            // Any reference to an identifier used here comes from outside the scope.
+            if (resource.getVariableDeclarations() instanceof J.Identifier) {
+                return false;
+            } else if (resource.getVariableDeclarations() instanceof J.VariableDeclarations) {
+                J.VariableDeclarations variableDeclarations = (J.VariableDeclarations) resource.getVariableDeclarations();
+                for (J.VariableDeclarations.NamedVariable variable : variableDeclarations.getVariables()) {
+                    // If the variable is not initialized with a new instance, it means it can come from outside the scope.
+                    if (!(variable.getInitializer() instanceof J.NewClass)) {
+                        return false;
+                    }
+                }
+            }
+        }
+        return true;
+    }
+
     private static class ExtractSideEffectsOfIfCondition<P> extends JavaVisitor<P> {
         private final J.Block enclosingBlock;
         private final J.If toExtract;

src/test/java/org/openrewrite/staticanalysis/EmptyBlockTest.java

@@ -416,7 +416,7 @@ public class A {
     }
 
     @Test
-    void emptyTryWithResources() {
+    void emptyTryWithResourcesWithExternalResources() {
         rewriteRun(
           //language=java
           java(
@@ -437,4 +437,53 @@ public void destroy() {
           )
         );
     }
+
+    @Test
+    void emptyTryWithResourcesWithVariableInitializationOfExternalResource() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import java.io.FileInputStream;import java.io.IOException;import java.io.InputStream;import java.io.UncheckedIOException;public class A {
+                  private final InputStream stdin = new FileInputStream("test.in");
+
+                  public void destroy() {
+                      // close stream in a try-with-resources
+                      try (InputStream s = stdin) {
+                      } catch (IOException e) {
+                          throw new UncheckedIOException(e);
+                      }
+                  }
+              }
+              """
+          )
+        );
+    }
+
+    @Test
+    void emptyTryWithResourcesWithVariableInitializationMethodInvocation() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import java.io.FileInputStream;import java.io.IOException;import java.io.InputStream;import java.io.UncheckedIOException;public class A {
+                  private final InputStream stdin = new FileInputStream("test.in");
+
+                  private InputStream getStdin() {
+                     return stdin;
+                  }
+
+                  public void destroy() {
+                      // close stream in a try-with-resources
+                      try (InputStream s = getStdin()) {
+                      } catch (IOException e) {
+                          throw new UncheckedIOException(e);
+                      }
+                  }
+              }
+              """
+          )
+        );
+    }
+
 }