Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for updating SDKMAN configuration #649

Merged
merged 14 commits into from
Dec 27, 2024
Merged

Conversation

nielsdebruin
Copy link
Contributor

What's changed?

A recipe that allows upgrading the SDKMAN's config file .sdkmanrc to a specific JDK, both the version and distribution can be modified either jointly or independently.

What's your motivation?

Implementation of:

Anything in particular you'd like reviewers to focus on?

Future work might look at a good way to retrieve the latest version of SDKMAN's JDKs

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@nielsdebruin nielsdebruin added the enhancement New feature or request label Dec 24, 2024
@nielsdebruin nielsdebruin self-assigned this Dec 24, 2024
nielsdebruin and others added 5 commits December 24, 2024 14:53
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/migrate/javax/AddJaxwsRuntime.java
    • lines 234-234
  • src/main/java/org/openrewrite/java/migrate/lang/var/DeclarationCheck.java
    • lines 58-58
  • src/main/java/org/openrewrite/java/migrate/lang/var/UseVarForPrimitive.java
    • lines 120-122
  • src/main/java/org/openrewrite/java/migrate/lombok/LombokValueToRecord.java
    • lines 120-120

@timtebeek timtebeek marked this pull request as draft December 24, 2024 15:32
@timtebeek timtebeek marked this pull request as ready for review December 27, 2024 13:16
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to bump these versions as well! I've replaced the hardcoded list you had, as well as the hard split on - as that did not work for .fx or .crac images. With that we're good to merge and include this by default going forward.

@timtebeek timtebeek merged commit 3f52b88 into main Dec 27, 2024
2 checks passed
@timtebeek timtebeek deleted the recipe/update-sdkmanrc branch December 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants