-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for updating SDKMAN configuration #649
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/migrate/javax/AddJaxwsRuntime.java
- lines 234-234
- src/main/java/org/openrewrite/java/migrate/lang/var/DeclarationCheck.java
- lines 58-58
- src/main/java/org/openrewrite/java/migrate/lang/var/UseVarForPrimitive.java
- lines 120-122
- src/main/java/org/openrewrite/java/migrate/lombok/LombokValueToRecord.java
- lines 120-120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to bump these versions as well! I've replaced the hardcoded list you had, as well as the hard split on -
as that did not work for .fx or .crac images. With that we're good to merge and include this by default going forward.
What's changed?
A recipe that allows upgrading the SDKMAN's config file
.sdkmanrc
to a specific JDK, both the version and distribution can be modified either jointly or independently.What's your motivation?
Implementation of:
.sdkmanrc
alongside Java upgrades #643Anything in particular you'd like reviewers to focus on?
Future work might look at a good way to retrieve the latest version of SDKMAN's JDKs
Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
Any additional context
Checklist