-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe that converts explicit setters to the lombok annotation #625
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
had copy-pasted from the example recipe
Hi @timo-a ; thanks for kicking off this one as well; I've resolved the conflicts with the main branch; are you ok to make the setter recipe behave more like the getter recipe we have? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ended up finishing the refactors on this one; thanks again @timo-a ! Great to have these two make it into the next release already.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Needs to be rebased onto main after #623 is merged, but I want to start working on this already.
TODO: reactivate commented out test
Checklist