-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe IllegalArgumentExceptionToAlreadyConnectedException
#615
Recipe IllegalArgumentExceptionToAlreadyConnectedException
#615
Conversation
…ptionToAlreadyConnectedException.java
src/main/java/org/openrewrite/java/migrate/MethodExceptionReplacerRecipe.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/migrate/MethodExceptionReplacerRecipe.java
Outdated
Show resolved
Hide resolved
IllegalArgumentExceptionToAlreadyConnectedException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so far @BhavanaPidapa ! I've pushed up a small change for a missing import after the migration; figured that'd help ensure the code compiles after the recipe runs.
In the PR description you also mention Class.getAnnotation, but I do not see that mentioned in the recipe or tests; is that still to come?
It is already covered in #613 |
Ok; good to merge then. I know @cjobinabo is out; let me know if you have any concerns or difficulties merging. |
Hey Tim, I don't have access to merge it seems. Can you please provide me the access. |
Thanks @BhavanaPidapa ; I've added you to the team, and merged the PR myself for now. :) |
What's changed?
This PR contains recipe - org.openrewrite.java.migrate.MethodExceptionReplacerRecipe
Rules:
What's your motivation?
A generic custom recipe for exception replacement based on method signatures. A common recipe is written to handle to both the rules.
Anything in particular you'd like reviewers to focus on?
For this rule already a custom recipe is written but now making use of this generic recipe instead of the previous one.
Anyone you would like to review specifically?
@timtebeek @cjobinabo
Checklist