New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metric registry creation #686

Merged

timtebeek merged 1 commit into openrewrite:main from ammachado:metrics-fix

Dec 14, 2023

Contributor

ammachado commented Dec 14, 2023

What's changed?

Different instances of MeterRegistry are created using MeterRegistryProvider#registry().

What's your motivation?

Use the maven plugin with rewrite.metricsUrl=LOG

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

I've added unit tests to cover both positive and negative cases
I've read and applied the recipe conventions and best practices
I've used the IntelliJ IDEA auto-formatter on affected files


          Fix meter registry creation

c310923

timtebeek merged commit af09205 into openrewrite:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet