Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keyof keyword #91

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Support keyof keyword #91

merged 3 commits into from
Nov 28, 2023

Conversation

kunli2
Copy link
Contributor

@kunli2 kunli2 commented Nov 28, 2023

fixes #90

currently, we have a model TypeOperator for type-operator, but I think it may be better to use a Unary to present type-operator since it's more generic.

@knutwannheden
Copy link
Contributor

currently, we have a model TypeOperator for type-operator, but I think it may be better to use a Unary to present type-operator since it's all generic.

What do you mean by "it's all generic"? I think a type operator is probably a hood idea, since the RHS might have zo be a type literal rather than any expression.

@kunli2
Copy link
Contributor Author

kunli2 commented Nov 28, 2023

What do you mean by "it's all generic"? I think a type operator is probably a hood idea, since the RHS might have zo be a type literal rather than any expression.

Oh, sorry, I mean maybe it's more generic to use a Unary

@kunli2 kunli2 merged commit 6ab4caf into main Nov 28, 2023
3 checks passed
@kunli2 kunli2 deleted the keyOf branch November 28, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support keyof operator keyword
2 participants