Add JS.Binary to support TS/JS specific binary type like in
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traceyyoshima
suggested changes
Nov 27, 2023
| @EqualsAndHashCode(callSuper = false, onlyExplicitlyIncluded = true) | ||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| @Data | ||
| final class Binary implements JS, Expression, TypedTree { |
There was a problem hiding this comment.
I think JsBinary should be renamed instead of adding a Binary class. The change will require an update in moderne-ast-write to handle existing JsBinary in old LSTs.
Alternatively, we can add a new issue and handle that later, while adding to the existing class.
There was a problem hiding this comment.
as discussed, this PR will update JsBinary instead of adding Binary and we will rename it later in a separate PR
…e that to Js.Binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
JS.Binaryto support TS/JS specific binary type likein