Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary calls to v8. #78

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Removed unnecessary calls to v8. #78

merged 1 commit into from
Nov 17, 2023

Conversation

traceyyoshima
Copy link
Contributor

@traceyyoshima traceyyoshima commented Nov 17, 2023 •
edited
Loading

Changes:

  • hasProperty is only used when the node isn't necessary.
  • Replaced uses of hasProperty with optional properties with null checks.

@traceyyoshima traceyyoshima force-pushed the remove-unnecssary-v8-calls branch from 261b65d to 3eef5f2 Compare November 17, 2023 17:44
@traceyyoshima traceyyoshima marked this pull request as ready for review November 17, 2023 17:46
@traceyyoshima traceyyoshima merged commit 3460f81 into main Nov 17, 2023
3 checks passed
@traceyyoshima traceyyoshima deleted the remove-unnecssary-v8-calls branch November 30, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden Awaiting requested review from knutwannheden

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@traceyyoshima