Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sum estimate time saved and log it #294

Merged
merged 7 commits into from
May 2, 2024
Merged

Sum estimate time saved and log it #294

merged 7 commits into from
May 2, 2024

Conversation

nicolasb29
Copy link
Contributor

@nicolasb29 nicolasb29 commented Mar 22, 2024 •
edited
Loading

#296

What's changed?

After log changes for each result, sum estimate time saved and log it.

What's your motivation?

OpenRewrite is working fine and it is very helpful. To show the importance and the time saved, I think it's interesting to show the estimate time saved.

Checklist

  • [X ] I've added unit tests to cover both positive and negative cases
  • [X ] I've read and applied the recipe conventions and best practices
  • [X ] I've used the IntelliJ IDEA auto-formatter on affected files

This was referenced Mar 22, 2024
Closed
Closed
@timtebeek timtebeek self-requested a review April 14, 2024 20:21
timtebeek
timtebeek reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the suggestion! I've proposed it internally to see if we want this on both of the OSS plugins, before I go and merge it here.

plugin/src/main/java/org/openrewrite/gradle/isolated/DefaultProjectParser.java Outdated Show resolved Hide resolved
@timtebeek timtebeek added the enhancement New feature or request label May 2, 2024
timtebeek
timtebeek approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Really good to show more folks how much time is saved. :)

plugin/src/main/java/org/openrewrite/gradle/isolated/DefaultProjectParser.java Outdated Show resolved Hide resolved
@timtebeek timtebeek merged commit 6388ebd into openrewrite:main May 2, 2024
1 check passed
@timtebeek timtebeek mentioned this pull request May 2, 2024
Closed
@timtebeek
Copy link
Contributor

Awesome work; I've logged an issue to remind myself we'll want the same for Maven

@nicolasb29 nicolasb29 mentioned this pull request May 2, 2024
Merged
@timtebeek timtebeek linked an issue May 3, 2024 that may be closed by this pull request
After rewrite, show the sum of estimate time saved #296
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@nicolasb29 nicolasb29

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After rewrite, show the sum of estimate time saved
2 participants
@nicolasb29 @timtebeek