Adds startup task to cancel previously running tasks #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 14, 2022
melisabok
reviewed
Jun 16, 2022
matcher/service/routes.py
Outdated
| @@ -97,6 +107,8 @@ def match(): | |||
|
|
|||
| interface.set_status(MatcherStatus.QUEUED) | |||
|
|
|||
| interface.validate_group(interface.match_group) | |||
There was a problem hiding this comment.
moving the call here is not going to reduce the response time in the POST /match call, why you don't want to put it inside the task?
melisabok
reviewed
Jun 16, 2022
|
|
||
| redis_conn = redis.Redis(connection_pool=redis_pool) | ||
| config_notes = redis_conn.hgetall(name="config_notes") | ||
| openreview_client = openreview.Client( |
There was a problem hiding this comment.
@carlosmondra to avoid using the super user to edit the notes, could we have a "matching" user or token? I can modify the invitation so the matching user is writer of all the configuration notes.
melisabok
reviewed
Jun 16, 2022
| key=note_id, | ||
| value=MatcherStatus.CANCELLED.value, | ||
| ) | ||
| config_note.content["status"] = MatcherStatus.CANCELLED.value |
There was a problem hiding this comment.
Could you add some description in the error message? "Matching run was cancelled, please try again"
…ide the matching task
…ew-matcher into feature/failed_tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.