Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dependencies nextflow workflow #17

Merged
merged 4 commits into from
Sep 20, 2024
Merged

fix dependencies nextflow workflow #17

merged 4 commits into from
Sep 20, 2024

Conversation

KaiWaldrant
Copy link
Member

@KaiWaldrant KaiWaldrant commented Sep 19, 2024 •
edited
Loading

Describe your changes

  • Update openproblems-v2 repo to openproblems
  • Update namespace of process_data dependency

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@KaiWaldrant KaiWaldrant changed the title fix dependencis nextflow workflow fix dependencies nextflow workflow Sep 19, 2024
rcannood
rcannood requested changes Sep 19, 2024
View reviewed changes
src/workflows/process_datasets/config.vsh.yaml Outdated Show resolved Hide resolved
src/workflows/run_benchmark/config.vsh.yaml Outdated Show resolved Hide resolved
rcannood
rcannood approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KaiWaldrant KaiWaldrant merged commit 16f5aee into main Sep 20, 2024
4 checks passed
@KaiWaldrant KaiWaldrant deleted the bugfix/no-ref/fix_datasets_wf branch September 20, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiWaldrant @rcannood