FIX: Bump ePub -> 1.3 in test audit. #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPUB now managed by W3C. Latest release is still in conjunction with IDPF, so for now they continue to be included in the agent name. Next iteration might switch to W3C only.
The following changes were made to support EPUBCheck 5.1.0: 1. New version lists resources with fragments making resource list much longer without reflecting new files in the package. Added logic to remove resources with fragments and only list base URL. 2. EPUBLocation changed slightly, updated code to manage support that change. 3. Some redundant messages were removed, which changed some message counts in tests - fixed message counts to reflect correct output. 4. Update validation version to 3.3 - there is no way to determine the minor version number in an EPUB, so validation is always against whatever the latest is. 5. CREATION_DATE is missing from the report, I've logged an issue and commented out the relevant lines in tests. It will be fixed in the next maintenance release and I will move to 5.1.1 when available to add creation date back in. 6. A file that was being used to test title has flipped from Well Formed and Valid to Well Formed and Not Valid according to current criteria - updated the test to reflect this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## integration #905 +/- ##
==============================================
Coverage 47.00% 47.00%
Complexity 1100 1100
==============================================
Files 57 57
Lines 9079 9079
Branches 1622 1622
==============================================
Hits 4268 4268
Misses 4280 4280
Partials 531 531 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes integration tests for #892 which is also included. Thanks @karenhanson