Update decidim-core/app/helpers/concerns/decidim/user_role_checker.rb

Co-authored-by: Alexandru Emil Lupu <[email protected]>
openpoke · Aug 12, 2024 · 9ee8c38 · 9ee8c38
1 parent bcbce2e
commit 9ee8c38
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/decidim-core/app/helpers/concerns/decidim/user_role_checker.rb b/decidim-core/app/helpers/concerns/decidim/user_role_checker.rb
@@ -30,12 +30,9 @@ def participatory_process_user_role?(user, participatory_process = nil)
 
     def assembly_user_role?(user, assembly = nil)
       return false unless Decidim.module_installed?(:assemblies)
+      return false unless assembly.is_a?(Decidim::Assembly)
 
-      if assembly.is_a?(Decidim::Assembly)
-        Decidim::AssemblyUserRole.exists?(user:, assembly:)
-      else
-        Decidim::AssemblyUserRole.exists?(user:)
-      end
+      Decidim::AssemblyUserRole.exists?(user:, assembly:)
     end
 
     def conference_user_role?(user, conference = nil)