refactor adjustCtasButtons function

openpoke · Jun 10, 2024 · 9ada1c1 · 9ada1c1
1 parent 13a8919
commit 9ada1c1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/decidim-core/app/packs/src/decidim/sticky_header.js b/decidim-core/app/packs/src/decidim/sticky_header.js
@@ -16,16 +16,14 @@ const adjustCtasButtons = () => {
     return;
   }
 
-  ctasButtons.forEach((ctasButton) => {
-    if (!ctasButton.offsetParent) {
-      return;
-    }
-    if (isElementInViewport(ctasButton)) {
-      footer.style.marginBottom = `${ctasButton.offsetHeight}px`;
-    } else {
-      footer.style.marginBottom = 0;
-    }
-  });
+  let visibleButtons = Array.from(ctasButtons).filter(isElementInViewport);
+
+  if (visibleButtons.length > 0) {
+    const marginBottom = Math.max(...visibleButtons.map((ctasButton) => ctasButton.offsetHeight));
+    footer.style.marginBottom = `${marginBottom}px`;
+  } else {
+    footer.style.marginBottom = 0;
+  }
 };
 
 if (stickyHeader) {

diff --git a/decidim-core/app/packs/stylesheets/decidim/_layout.scss b/decidim-core/app/packs/stylesheets/decidim/_layout.scss
@@ -117,6 +117,6 @@
   }
 
   .survey-section-buttons {
-    @apply flex-row last:[&>button]:font-semibold last:[&>button]:text-lg last:[&>button]:py-3;
+    @apply h-20 flex-row last:[&>button]:font-semibold last:[&>button]:text-lg last:[&>button]:py-3;
   }
 }