Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forced downcase in custom redirect urls #21

Closed
wants to merge 3 commits into from

Conversation

ElviaBth
Copy link

@ElviaBth ElviaBth commented Oct 30, 2023

🎩 What? Why?

When admin saves the redirect it honors the case that was saved and doesn't convert it all to lowercase. Admin expects that either it would respect the case sensitivity or the case sensitivity would not matter at all, and the feature should work as expected.

📌 Related Issues

Testing

  • when origin and destination are not case sensitive

📷 Screenshots

image

♥️ Thank you!

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@5a99411). Click here to learn what that means.

❗ Current head 6db96d1 differs from pull request most recent head 48d759d. Consider uploading reports for the commit 48d759d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #21   +/-   ##
==========================================
  Coverage           ?   96.02%           
==========================================
  Files              ?       97           
  Lines              ?     2440           
  Branches           ?        0           
==========================================
  Hits               ?     2343           
  Misses             ?       97           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@microstudi microstudi closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants