Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip Feeder Moves to Wrong Pick Position Before First Feed #352

Closed
vonnieda opened this issue Oct 26, 2016 · 0 comments
Closed

Strip Feeder Moves to Wrong Pick Position Before First Feed #352

vonnieda opened this issue Oct 26, 2016 · 0 comments
Labels
enhancement help-wanted

Comments

@vonnieda
Copy link
Member

Currently the strip feeder will position at the pocket before the first one when the feed count is 0. This happens after setting up a feeder and before running the first feed. This is confusing to users. It would be better if it positioned at the first pocket during feed 0 and feed 1.

Per this discussion https://groups.google.com/d/msgid/openpnp/98625804-281f-4fab-9e8b-37c03228211a%40googlegroups.com?utm_medium=email&utm_source=footer
vonnieda added a commit that referenced this issue Nov 11, 2016
@vonnieda
Merge branch 'develop' into feature/uvc-camera
3eb6108 
* develop: (32 commits)
  Untitled machine setup tabs filled
  moving generic code for feeders to base class
  moved generic code for cameras to base class ReferenceCamera
  Feeders configuration tab in "Machine Setup" panel no titled with "Configuration"
  Configuration tabs within "Machine Setup" panel now with title
  Added further improvement to startup message by adding 'Namste' along with multi language 'Hello'
  Feeder panel layout in line with other panels
  executing "first pull" tutorial
  Improves error messages for fidicual detection. In particular, the "width and height must be > 0" error that is hard to track down is now much improved and explains how to resolve it.
  Fixes log level initialization error when loading an old config key.
  Add SLF4j-log4j back in as removing it seems to have broken the WebcamCamera.
  Updated CHANGES.md
  Fixes #354, adds a fourth move to the nozzle tip changer. The additional move is placed in the middle and for backwards compatibilty it will be cloned from the previous middle move upon first config load.
  Fix a small bug in scripting read. Thanks @cri-s.
  Update CHANGES.md
  Updates changes for recent changes.
  Fixes #333, logging is now handled by tinylog and uses a very simple default configuration. Log level can be managed in the log tab. Logs are captured to rotating files, similar to before, to the log window and to the console.
  Ripped out slf and log4j and replaced with tinylog + a small wrapper. Wrapper is just so I don't have to touch every class yet. Will be removed. Logging window now controls logging entirely.
  Fixes #347, camera view reticles now track the tools rotation, instead of the camera's rotation.
  Fixes #352, strip feeder now treats feedCount 0 as feedCount 1 for the purposes of returning pick location.
  ...

# Conflicts:
#	pom.xml
vonnieda added a commit that referenced this issue Nov 11, 2016
@vonnieda
Merge branch 'develop' into feature/loose-part-feeder
880019e 
* develop: (96 commits)
  Untitled machine setup tabs filled
  moving generic code for feeders to base class
  moved generic code for cameras to base class ReferenceCamera
  Feeders configuration tab in "Machine Setup" panel no titled with "Configuration"
  Configuration tabs within "Machine Setup" panel now with title
  Added further improvement to startup message by adding 'Namste' along with multi language 'Hello'
  Feeder panel layout in line with other panels
  executing "first pull" tutorial
  Improves error messages for fidicual detection. In particular, the "width and height must be > 0" error that is hard to track down is now much improved and explains how to resolve it.
  Fixes log level initialization error when loading an old config key.
  Add SLF4j-log4j back in as removing it seems to have broken the WebcamCamera.
  Updated CHANGES.md
  Fixes #354, adds a fourth move to the nozzle tip changer. The additional move is placed in the middle and for backwards compatibilty it will be cloned from the previous middle move upon first config load.
  Fix a small bug in scripting read. Thanks @cri-s.
  Update CHANGES.md
  Updates changes for recent changes.
  Fixes #333, logging is now handled by tinylog and uses a very simple default configuration. Log level can be managed in the log tab. Logs are captured to rotating files, similar to before, to the log window and to the console.
  Ripped out slf and log4j and replaced with tinylog + a small wrapper. Wrapper is just so I don't have to touch every class yet. Will be removed. Logging window now controls logging entirely.
  Fixes #347, camera view reticles now track the tools rotation, instead of the camera's rotation.
  Fixes #352, strip feeder now treats feedCount 0 as feedCount 1 for the purposes of returning pick location.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vonnieda