misc OpenBSD 6 related fixes #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Jeff Squyres <[email protected]> Date: Mon Mar 9 08:15:38 2015 -0700 pmix_check_package: use AC_SEARCH_LIBS instead of AC_CHECK_LIB Per discussion on devel (http://www.open-mpi.org/community/lists/devel/2015/02/17030.php), and per Autoconf 2.69 docs, use the recommended AC_SEARCH_LIBS instead of AC_CHECK_LIB (e.g., for functions that appear in libc on some platforms and in a specific library on other platforms). see open-mpi/ompi@d6530b0 Refs open-mpi/ompi#2106 Signed-off-by: Gilles Gouaillardet <[email protected]>
Refs. open-mpi/ompi#2106 Signed-off-by: Gilles Gouaillardet <[email protected]>
|
@ggouaillardet If I read this correctly, we are indeed restoring the original LDFLAGS when we are done with searching - correct? I think it's important that we do so. |
|
I guess it also hits LIBS as well, but I gather we protect it too. |
|
@rhc54 @PHHargrove this is correct so i think we are good |
PHHargrove
approved these changes
Feb 24, 2017
|
@ggouaillardet this resolves the issue that has been blocking my ability to test open-mpi/ompi#2107 |
|
@ggouaillardet @PHHargrove Thanks to both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Paul Hargrove for bringing this to our attention
Refs open-mpi/ompi#2106