Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix #454 #wip #488

Merged
merged 4 commits into from
Aug 14, 2023
Merged

bug fix #454 #wip #488

merged 4 commits into from
Aug 14, 2023

Conversation

kathryn-ods
Copy link
Contributor

removing 'securitiesListing' from the required properties on 'publicListing'

Overview

  • What does this pull request do?
    make securitiesListing not required
  • How can a reviewer test or examine your changes?
    eyeball
  • Who is best placed to review it?
    kadie

(Closes/Relates to) issue: #454

Translations

n/a

Documentation & Release

removing 'securitiesListing' from the required properties on 'publicListing'
@kathryn-ods kathryn-ods requested a review from kd-ods August 9, 2023 14:57
@kathryn-ods kathryn-ods changed the title bug fix #454 bug fix #454 #wip Aug 9, 2023
@kathryn-ods kathryn-ods mentioned this pull request Aug 9, 2023
@kd-ods
Copy link
Collaborator

kd-ods commented Aug 9, 2023

There is test which needs to be removed before checks clear on this PR: data/entity-statement/invalid/invalid-entity-statement-no-securitiesListings.json

@kd-ods
Copy link
Collaborator

kd-ods commented Aug 10, 2023

@kathryn-ods - you can go ahead and update the changelog on this WIP branch now. There's guidance here about what to do, but basically you can add a new 'unreleased' heading then detail this little change under a 'Changed' subheading.

Have a go and I can review it from this PR. Ping me if you need to.

Copy link
Collaborator

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog and everything looks good. This is ready to merge.

@kd-ods kd-ods merged commit 580edd0 into main Aug 14, 2023
2 checks passed
@kd-ods kd-ods deleted the kathryn-ods-patch-1 branch August 14, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants