-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toc calculations #147
base: master
Are you sure you want to change the base?
Toc calculations #147
Conversation
This is probably the reason why we had the larger spacing at the bottom of the page. - We could potentially print à "-" to indicate that there are no themes in this category. Or we increase the spacing to 2cm. |
The dash sounds good to me as we have this element already in use at "Übrige Legende (im sichtbaren Bereich)" for the case of no items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did test the branch within our environment. However, table of contents page did not change. The block around the general information and QR Code are all on the second page.
Maybe we'll need more testing from other cantons?
@svamaa depending on the number of themes, that is possible. More testing is always helpful 👍 |
This is our (TI) PDF output with this #147 merged. |
This version of the templates adapts the line heights and spacings in the TOC page and the associated subreports where different field sizes have been defined.
TOC calculations should be simplified this way and the pdf creation should still work as expected
This leads to a lot more of the PDF's with only one TOC page in our case.
new:
20241025085449_extract.pdf
before:
66aca8c4-101f-4b40-b6ab-b1841f111be5.pdf
You may wan't to try this branch of mfp with the toc_calculations branch: PR openoereb/pyramid_oereb#2047