-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise toc calculation #2047
Open
peterschaer
wants to merge
12
commits into
master
Choose a base branch
from
revise_toc_calculation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Revise toc calculation #2047
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fb93b93
rework toc length calculation (#2038)
peterschaer 0e3332d
rework toc length calculation - all values from toc.jrxml (#2038)
peterschaer 0117755
Linting (#2038)
peterschaer 90affa3
Fixing test (#2038)
peterschaer 6bb3c87
better logging of toc length calculation (#2038)
peterschaer 2ebf392
toc length calculation includes law_status (#2038)
peterschaer 6951b23
toc length calculation includes page margins (top and bottom) (#2038)
peterschaer 08e0519
toc length calculation bugfix in footer (#2038)
peterschaer c42451a
toc length calculation linting (#2038)
peterschaer 6f1cf48
toc lenght calculation - fix tests (#2038)
peterschaer a5bc344
toc length calculation - fix tests 2 (#2038)
peterschaer 36f687d
Toc length calculation bufix d3 and d5 (#2038)
peterschaer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
total_size
is always zero.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted, thanks! I just commited a bugfix.